Add regression tests #18240
Merged
Add regression tests #18240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def unapply(expr: Expr[QueryMeta[T]])(using q: Quotes): Option[QueryMeta[T]] = | ||
| import q.reflect.* | ||
| expr match | ||
| case '{ QueryMeta[t](${ map }: Map[String, String]) } => |
There was a problem hiding this comment.
Suggested change
| case '{ QueryMeta[t](${ map }: Map[String, String]) } => | |
| case '{ QueryMeta(${ map }: Map[String, String]) } => |
Shouldn't we use only either instance of Type[T] (variant a) or only type extractor [t] (variant b)?
There was a problem hiding this comment.
This one was supposed to be
case '{ QueryMeta[T](${ map }: Map[String, String]) } =>I pushed a fixed version.
WojciechMazur
approved these changes
Jul 19, 2023
Kordyjan
added a commit
that referenced
this pull request
Dec 8, 2023
Backports #18240 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18228